There always needs to be a balance of security and convenience. If you make security to cumbersome then end users are just as likely to go without. I think another distinction is that privacy != security and security != privacy although they do go hand in hand.

Some examples would be disabling all iCloud services. That seems rather cumbersome for limited benefit. It will reduce your attack surface to just your single device but also introduces a single point of failure and may result in less secure methods to make data available and result in insecure or unreliable backups like backing data up to an unencrypted single drive.

I do recommend advanced data protection like he says.

Disabling the Find My network does increase privacy from shoulder surfers and people who may physically compromise the device but most people are OK with that to be able to easily find their items and know where their loved ones are.

Disabling Face ID is another thing that would protect you from physical compromise (someone can’t hold you down and force you to scan your face) but over all I would rather require a long alphanumeric+symbol passcode rather than disable Face ID. You have a much more higher risk of someone watching over your shoulder for a 6 digit passcode than you do someone kidnapping you and having free access to scan your face.

Other things are out of date, such as iCloud supporting S/MIME by default and encrypting mail at rest.

Overall I would take the advice with a grain of salt as most settings are a good idea to disable but others are a bit overzealous and without much thought in my opinion.