• 1 Post
  • 107 Comments
Joined 1 year ago
cake
Cake day: July 1st, 2023

help-circle

  • One day you will inherit a code base so bad that you’ll end up commenting old code

    Will not be the case, I won’t take a job, where I have this situation (or I’ll quit pretty quickly)…

    Yeah my “comment standards” (btw. as others mentioned here, I was unprecise/unlucky with the choice of words, I meant “comment the why” or doc-comments totally fine and should be aimed)

    Your so called comment standards and principals are fine if you are building something from the ground up

    Yes that was also targeted with my comment. But what you’re referring to is just missing documentation, and I think this should be done on a higher level. The “comment why” rule applies for spaghetti code non-the-less…

















  • philm@programming.devtoProgrammer Humor@programming.devYes
    link
    fedilink
    arrow-up
    10
    arrow-down
    5
    ·
    edit-2
    8 months ago

    but effectively it’s bash, I think /bin/sh is a symlink to bash on every system I know of…

    Edit: I feel corrected, thanks for the information, all the systems I used, had a symlink to bash. Also it was not intended to recommend using bash functionality when having a shebang !#/bin/sh. As someone other pointed out, recommendation would be #!/usr/bin/env bash, or !#/bin/sh if you know that you’re not using bash specific functionality.



  • misunderstanding was

    I think here’s a misunderstanding too :). With quickly I mean closing without getting feedback, or without providing a good reason why the issue is closed (without being obviously resolved), not the dates (which I think are only relevant, when actually awaiting a response). I have seen this over the repo a few times, good writeups often explaining some behavior etc. and then bam closed, either as duplicate (although it’s not (example)), or “not as planned” etc. I think this is not good behavior for an open source project (I’m around the block for a few years contributing and maintaining OSS, for reference…). Especially as this is a real community project and not some random opinionated application (well depending on how you define it, could be true to lemmy, but I don’t think it is…)

    I rather let an issue open than close it, “just to have fewer open issues”. I can close it anytime, and if someone searches for that issue sees it closed while it isn’t resolved, it just creates confusion…